fix: Add automatic MIME type detection for file uploads #2520
+140
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add _guess_content_type_from_filename() for filename-based detection - Add _sniff_content_type_from_bytes() for content-based detection - Add _ensure_tuple_with_content_type() helper function - Enhance _transform_file() and _async_transform_file() to include content types - Support PDF, PNG, JPEG, GIF detection from file signatures - Fixes openai#2472: PDF upload via Files API now includes proper Content-Type This resolves the 400 Bad Request error when uploading PDF files for streaming use cases.
rickpr
suggested changes
Aug 7, 2025
- Add _guess_content_type_from_filename() for filename-based detection - Add _sniff_content_type_from_bytes() for content-based detection - Add _ensure_tuple_with_content_type() helper function - Enhance _transform_file() and _async_transform_file() to include content types - Support PDF, PNG, JPEG, GIF detection from file signatures - Fixes openai#2472: PDF upload via Files API now includes proper Content-Type This resolves the 400 Bad Request error when uploading PDF files for streaming use cases.
rickpr
reviewed
Aug 7, 2025
rickpr
approved these changes
Aug 7, 2025
Diagolex
approved these changes
Aug 9, 2025
danowar2
approved these changes
Aug 10, 2025
danowar2
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the 400 Bad Request error when uploading PDF files for streaming use cases.
example :
Before :
After :
Additional context & links